Skip to content

fix(init): normalize node runtime before linters#267

Merged
zeitlinger merged 2 commits intomainfrom
codex/init-node-before-linters
May 6, 2026
Merged

fix(init): normalize node runtime before linters#267
zeitlinger merged 2 commits intomainfrom
codex/init-node-before-linters

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented May 6, 2026

What changed

This updates flint init so the node runtime is added before [tools] normalization when an npm: backend tool such as npm:renovate is selected.

Why

init already ensured node indirectly through the later migration pass, but that happened after [tools] normalization. The result was a valid mise.toml with node appended under the # Linters block instead of being grouped with runtime tools above it.

Impact

Generated mise.toml files now keep node in the runtime section while still adding it automatically for npm: tools.

Root cause

The init flow normalized [tools] before calling the helper that inserts node, so the final write order was wrong even though the dependency was present.

Validation

  • cargo test init::tests::node_added_for_npm_tools_is_normalized_above_linters_header -- --exact
  • cargo test init::tests::normalize_tools_section_moves_node_above_linters_header -- --exact
  • cargo test init::tests::compute_desired_tools_comprehensive_includes_slow -- --exact
  • mise run lint:fix

@zeitlinger
fix(init): normalize node runtime before linters
7c5c2a9 
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger marked this pull request as ready for review May 6, 2026 07:53
@zeitlinger zeitlinger requested a review from a team as a code owner May 6, 2026 07:53
Copilot AI review requested due to automatic review settings May 6, 2026 07:53
Copilot AI reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the flint init write flow so that when an npm: backend tool (e.g., npm:renovate) is selected, the required node runtime is inserted before [tools] normalization—keeping node grouped with runtime tools above the # Linters block in generated mise.toml.

Changes:

  • Call ensure_node_for_npm(project_root) before normalize_tools_section(&mise_path) during init.
  • Include node_added in the “No changes to apply.” noop decision.
  • Add a unit test intended to validate node placement relative to the linters header for npm: tools.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/init/mod.rs Reorders init steps to ensure node is added prior to [tools] normalization and updates noop detection.
src/init/tests.rs Adds a test around npm:renovate + ensure_node_for_npm + normalization to assert node remains above # Linters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/init/tests.rs Outdated
@zeitlinger
test(init): cover node ordering via init run
8de3452 
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger merged commit c215197 into main May 6, 2026
13 checks passed
@zeitlinger zeitlinger deleted the codex/init-node-before-linters branch May 6, 2026 13:10
This was referenced May 8, 2026
Closed
Merged
zeitlinger pushed a commit that referenced this pull request May 11, 2026
@github-actions
chore: release v0.22.0 (#279)
c3fc3fa 
## 🤖 New release

* `flint`: 0.21.0 -> 0.22.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.22.0](v0.21.0...v0.22.0)
- 2026-05-11

### Added

- replace codespell with typos
([#269](#269))
- *(lychee)* add local cache for local runs
([#268](#268))

### Fixed

- *(renovate-deps)* surface real renovate failure in error output
([#278](#278))
- *(ci)* drop double release-plz update from release:pr
([#276](#276))
- *(init)* normalize node runtime before linters
([#267](#267))
- *(renovate)* support block-scalar mise sha256 values
([#266](#266))
- *(mise)* migrate flint-managed tools to supported backends
([#258](#258))
- validate renovate dependency rule coverage
([#263](#263))
- make flint-setup state-based
([#252](#252))
- *(init)* let rustfmt own Rust line length
([#250](#250))
- run renovate-deps for deleted tracked files
([#247](#247))
- validate CI env and isolate check types
([#253](#253))
- *(init)* remove stale head sha from CI snippets
([#248](#248))
- *(init)* enable yamllint indentation rule
([#251](#251))

### Other

- streamline README getting started
([#280](#280))
- *(deps)* update taiki-e/install-action digest to fa0dd4c
([#282](#282))
- *(deps)* lock file maintenance
([#285](#285))
- *(deps)* update dependency mise to v2026.5.2
([#284](#284))
- *(deps)* update dependency go to v1.26.3
([#283](#283))
- *(deps)* update taiki-e/install-action digest to e3134ec
([#281](#281))
- pass git-token and forge to release-plz
([#274](#274))
- *(deps)* update taiki-e/install-action digest to 3fa6878
([#275](#275))
- *(deps)* bump renovate to 43.150.0
([#273](#273))
- [**breaking**] drop --fast-only flag and tighten renovate-deps timing
([#270](#270))
- *(deps)* update rust crate tokio to v1.52.2
([#272](#272))
- upgrade lychee to v0.24.2
([#265](#265))
- *(deps)* update taiki-e/install-action digest to cca35ed
([#254](#254))
- *(deps)* update dependency aqua:owenlamont/ryl to v0.8.0
([#261](#261))
- *(deps)* update dependency mise to v2026.4.28
([#262](#262))
- *(deps)* update dependency golangci-lint to v2.12.1
([#264](#264))
- *(deps)* update dependency aqua:owenlamont/ryl to v0.7.0
([#259](#259))
- *(renovate)* simplify quickstart and batch weekly linter updates
([#257](#257))
- *(deps)* update dependency npm:renovate to v43.141.6
([#255](#255))
- expand positioning and comparisons
([#239](#239))
- *(deps)* update taiki-e/install-action digest to 1f2425c
([#246](#246))
- move release-plz flow into mise tasks
([#234](#234))
- *(deps)* update taiki-e/install-action digest to 481c34c
([#231](#231))
- *(deps)* update dependency ruff to v0.15.12
([#245](#245))
- *(deps)* update dependency npm:renovate to v43.141.5
([#244](#244))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@martincostello martincostello martincostello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeitlinger @martincostello